-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in Track's magnetic field determination #9874
Conversation
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
The PR also contains changes for stand-alone version of cmsShow. |
-1 Need to add one more change. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix bug in Track's magnetic field determination
A FWMagField::m_source was not updated in FWMagField::checkFieldInfo(). This flag was read in the Track proxy builder which did field estimation instead of getting field from event data:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/Fireworks/Tracks/plugins/FWTrackProxyBuilder.cc#L65